On Tue, Dec 17, 2013 at 05:08:52PM -0500, Gary Rookard wrote:
> - //DDR INIT-133Mhz
> -#define T3_SKIP_CLOCK_PROGRAM_DUMP_133MHZ 12 //index for 0x0F007000
> -static struct bcm_ddr_setting asT3_DDRSetting133MHz[] = {// # DPLL Clock Setting
> + /* DDR INIT-133Mhz */
This is indented in a funny way.
> +#define T3_SKIP_CLOCK_PROGRAM_DUMP_133MHZ 12 /* index for 0x0F007000 */
> +static struct bcm_ddr_setting asT3_DDRSetting133MHz[] = {/* DPLL Clock Setting */
Put a space between the '{' and the "/*".
> {0x0F007018, 0x01000000},
> - {0x0F00701c, 0x01020001},// POP - 0x00020001 Normal 0x01020001
> - {0x0F007020, 0x04030107}, //Normal - 0x04030107 POP - 0x05030107
> + {0x0F00701c, 0x01020001},/* POP - 0x00020001 Normal 0x01020001 */
> + {0x0F007020, 0x04030107}, /* Normal - 0x04030107 POP - 0x05030107 */
> {0x0F007024, 0x02000007},
> {0x0F007028, 0x02020202},
> - {0x0F00702c, 0x0206060a},//ROB- 0x0205050a,//0x0206060a
> + {0x0F00702c, 0x0206060a},/* ROB- 0x0205050a,//0x0206060a */
> {0x0F007030, 0x05000000},
> {0x0F007034, 0x00000003},
> - {0x0F007038, 0x110a0200},//ROB - 0x110a0200,//0x180a0200,// 0x1f0a0200
> - {0x0F00703C, 0x02101010},//ROB - 0x02101010,//0x02101018},
> - {0x0F007040, 0x45751200},//ROB - 0x45751200,//0x450f1200},
> - {0x0F007044, 0x110a0d00},//ROB - 0x110a0d00//0x111f0d00
> + {0x0F007038, 0x110a0200},/* ROB - 0x110a0200,//0x180a0200,// 0x1f0a0200 */
> + {0x0F00703C, 0x02101010},/* ROB - 0x02101010,//0x02101018}, */
> + {0x0F007040, 0x45751200},/* ROB - 0x45751200,//0x450f1200}, */
> + {0x0F007044, 0x110a0d00},/* ROB - 0x110a0d00//0x111f0d00 */
> {0x0F007048, 0x081b0306},
It's not clear what these comments are supposed to be. Just delete
them.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
