Re: [PATCH 1/3] vme_user: Ensure driver compiles after VME bridges

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/12/13 00:29, Aaron Sierra wrote:
> 
> Martyn,
> Your suggestion resolves the kernel panic associated with the vme_user
> driver being initialized before the VME bus core driver, but it doesn't
> address the issue of the vme_user driver being registered before any
> buses have been probed:
> 
> [snip]
> usbhid: USB HID core driver
> vme_user: VME User Space Access Driver
> vme_user: No cards, skipping registration
> vme_tsi148 0000:04:04.0: Board is the VME system controller
> vme_tsi148 0000:04:04.0: VME geographical address is 1
> vme_tsi148 0000:04:04.0: VME Write and flush and error check is disabled
> vme_tsi148 0000:04:04.0: CR/CSR Offset: 1
> vme_tsi148 0000:04:04.0: Enabling CR/CSR space
> [snip]
> 

I have a feeling that aren't correctly registering the driver or bridges in
the core code. I'd have expected the match routine to be called when a bridge
is registered on the system (much as USB mass storage devices get recognised
as such when they are inserted).

> Resolving the kernel panic seems like a more immediate priority, though, so
> I will submit my version of this patch. I plan to include your Signed-off-by
> since you suggested the code change, unless you have an argument against
> me doing so.
> 

No problem here.

Martyn

> -Aaron
> 


-- 
Martyn Welch (Lead Software Engineer)  | Registered in England and Wales
GE Intelligent Platforms               | (3828642) at 100 Barbirolli Square
T +44(0)1327322748                     | Manchester, M2 3AB
E martyn.welch@xxxxxx                  | VAT:GB 927559189
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux