Re: [PATCH 1/3] vme_user: Ensure driver compiles after VME bridges

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



----- Original Message -----
> From: "Martyn Welch" <martyn.welch@xxxxxx>
> 
> I'm sorry, this is not a fix.
> 
> Martyn

Martyn,
Can you please elaborate on why you feel it is not a fix? For instance,
will this type of solution not be accepted upstream? Is this solution not
complete enough? Do you feel that it doesn't resolve any issue?

-Aaron

> 
> On 31/10/13 23:47, Aaron Sierra wrote:
> > If VME bridge and vme_user modules are compiled into the kernel, then
> > vme_user will attempt to register itself before any VME buses have been
> > probed. This results in a kernel panic.
> > 
> > This patch removes the staging VME devices build from the general
> > staging Makefile and moves the build to the general VME Makefile after
> > all VME buses are built.
> > 
> > Signed-off-by: Aaron Sierra <asierra@xxxxxxxxxxx>
> > ---
> >  drivers/staging/Makefile |    1 -
> >  drivers/vme/Makefile     |    1 +
> >  2 files changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
> > index 415772e..8082bdb 100644
> > --- a/drivers/staging/Makefile
> > +++ b/drivers/staging/Makefile
> > @@ -27,7 +27,6 @@ obj-$(CONFIG_USB_SERIAL_QUATECH2)	+= serqt_usb2/
> >  obj-$(CONFIG_OCTEON_ETHERNET)	+= octeon/
> >  obj-$(CONFIG_VT6655)		+= vt6655/
> >  obj-$(CONFIG_VT6656)		+= vt6656/
> > -obj-$(CONFIG_VME_BUS)		+= vme/
> >  obj-$(CONFIG_DX_SEP)            += sep/
> >  obj-$(CONFIG_IIO)		+= iio/
> >  obj-$(CONFIG_ZRAM)		+= zram/
> > diff --git a/drivers/vme/Makefile b/drivers/vme/Makefile
> > index d7bfcb9..7a784ab 100644
> > --- a/drivers/vme/Makefile
> > +++ b/drivers/vme/Makefile
> > @@ -5,3 +5,4 @@ obj-$(CONFIG_VME_BUS)		+= vme.o
> >  
> >  obj-y				+= bridges/
> >  obj-y				+= boards/
> > +obj-$(CONFIG_STAGING)		+= ../staging/vme/
> > 
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux