On Tue, Dec 10, 2013 at 09:30:43PM +0000, Ian Abbott wrote:
>
> It might be better just to prevent comedi_load_firmware() returning
> a value greater than zero, since I can't think of any reason why it
> would need to. That would also work for the usbdux driver.
>
Yeah. It looks like it's usbduxfast_upload_firmware() which has the
problem. Does this fix your problem? This bug was introduced in
161f440c8d91 ('staging: comedi: drivers: usbduxfast.c: fix for DMA
buffers on stack')
diff --git a/drivers/staging/comedi/drivers/usbduxfast.c b/drivers/staging/comedi/drivers/usbduxfast.c
index 9707dd1239c4..f2d8d7fb7aab 100644
--- a/drivers/staging/comedi/drivers/usbduxfast.c
+++ b/drivers/staging/comedi/drivers/usbduxfast.c
@@ -1040,6 +1040,7 @@ static int usbduxfast_upload_firmware(struct comedi_device *dev,
EZTIMEOUT);
if (ret < 0)
dev_err(dev->class_dev, "can not start firmware\n");
+ ret = 0;
done:
kfree(tmp);
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
