RE: [PATCH 00/51] staging: comedi: cleanup irq requests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday, December 04, 2013 4:47 AM, Ian Abbott wrote:
> On 2013-12-03 19:07, H Hartley Sweeten wrote:
>> The comedi subsystem only requires the drivers to support interrupts if one
>> or more of the subdevices support async commands. Since this is optional:
>>
>> 1) don't fail the attach if the irq is not available
>> 2) only hookup the async command support if the irq is available
>> 3) remove any async command init from subdevices that don't need it
>> 4) remove any unnecessary sanity checks in the async command functions
>>
>> Make use of the comedi_device 'read_subdev' and 'write_subdev' pointers
>> instead of accessing the dev->subdevices array directly with "magic" numbers
>> to the correct subdevice.
>>
>> Also, remove any unnecessary debug noise associated with the irq requests.
>
> I have issues with patches 18, 19, 22, and 49, although patch 19 is 
> fixed by patch 20.
>
> Patch 27 may be considered for stable kernels 3.7 and later if it 
> applies cleanly (I need to check).

Ian,

Greg has applied patches 1-17 to his tree. I will drop the offending pieces in
patches 18, 19, 22, and 49 and repost the series later today.

I'll leave the backport of patch 27 to you.

Thanks,
Hartley

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux