Re: [PATCH 04/11] staging: et131x: drop packet when error occurs in et131x_tx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 04, 2013 at 03:23:29PM -0800, Greg Kroah-Hartman wrote:
> On Wed, Dec 04, 2013 at 03:24:14PM +0800, ZHAO Gang wrote:
> > As TODO file suggested, drop packet instead of return NETDEV_TX_BUSY
> > when tx failed.
> 
> Really?  That's ok to do?  Seems like you are changing the logic of the
> function a lot here, how does the code let userspace know packets were
> dropped then?

The TODO file item was a suggestion by David Miller from the last review
- http://lkml.org/lkml/2013/1/28/756

Mark
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux