On Mon, Nov 04, 2013 at 12:08:50PM -0500, Steven Rostedt wrote: > On Mon, 4 Nov 2013 02:11:50 +0300 > Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > > On Sun, Nov 03, 2013 at 10:28:02AM -0800, Josh Triplett wrote: > > > On Tue, Oct 29, 2013 at 11:01:43PM +0300, Dan Carpenter wrote: > > > > The icount.reserved[] array isn't initialized so it leaks stack > > > > information to userspace. > > > > > > > > Reported-by: Nico Golde <nico@xxxxxxxxx> > > > > Reported-by: Fabian Yamaguchi <fabs@xxxxxxxxx> > > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > > > > > Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx> > > > > > > Also, you don't quite have the patch format right here; you should have > > > a --- line after the commit mesage, followed by a diffstat. Did you use > > > git format-patch to generate this patch? > > > > I normally don't include the diffstat. Which tools care about that? > > > > As Josh already replied, it is most helpful for the human reviewer. > Linus uses it all the time to see how intrusive a patch may be. > > Yes, please always include a diffstat for any patch you send. It sounds simple to add a diffstat but it's sort of a pain to redo my workflow... I don't use git commits. If I need to make the same change to multiple files then I end up appending the diff to the end of an existing email and tweaking the diff hunks together by hand. I guess I could writing an append_diff.sh script which munges the diffstat but it seems like it might be error prone. I'll take a look though. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
