Re: [patch] Staging: sb105x: info leak in mp_get_count()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Nov 03, 2013 at 10:28:02AM -0800, Josh Triplett wrote:
> On Tue, Oct 29, 2013 at 11:01:43PM +0300, Dan Carpenter wrote:
> > The icount.reserved[] array isn't initialized so it leaks stack
> > information to userspace.
> > 
> > Reported-by: Nico Golde <nico@xxxxxxxxx>
> > Reported-by: Fabian Yamaguchi <fabs@xxxxxxxxx>
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
> 
> Also, you don't quite have the patch format right here; you should have
> a --- line after the commit mesage, followed by a diffstat.  Did you use
> git format-patch to generate this patch?

I normally don't include the diffstat.  Which tools care about that?

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux