On Mon, Nov 04, 2013 at 10:01:00AM +0300, Dan Carpenter wrote: > I've dropped most of the people from the CC list. > > On Sun, Nov 03, 2013 at 08:31:50PM -0800, Josh Triplett wrote: > > On Mon, Nov 04, 2013 at 02:11:50AM +0300, Dan Carpenter wrote: > > > On Sun, Nov 03, 2013 at 10:28:02AM -0800, Josh Triplett wrote: > > > > On Tue, Oct 29, 2013 at 11:01:43PM +0300, Dan Carpenter wrote: > > > > > The icount.reserved[] array isn't initialized so it leaks stack > > > > > information to userspace. > > > > > > > > > > Reported-by: Nico Golde <nico@xxxxxxxxx> > > > > > Reported-by: Fabian Yamaguchi <fabs@xxxxxxxxx> > > > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > > > > > > > Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx> > > > > > > > > Also, you don't quite have the patch format right here; you should have > > > > a --- line after the commit mesage, followed by a diffstat. Did you use > > > > git format-patch to generate this patch? > > > > > > I normally don't include the diffstat. Which tools care about that? > > > > Human wetware. :) > > > > It isn't required by any tools. The --- is, though, to produce > > something applicable by git. > > That's really weird. I've been using the same scripts for years and no > one has complained before. The patch applies fine with `git am` for me. > I'm using git version 1.7.10.4. I stand corrected. I was under the impression that the --- was required to mark the end of the commit message, but sure enough, git am seems to accept it. Reading the git am manpage, it says that a line starting with "diff -" will also indicate the end of the commit message and start of the patch. It still isn't the conventional format produced by git format-patch, which I'd recommend matching for ease of human consumption, but nonetheless it apparently works. - Josh Triplett _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
