Re: [PATCH 1/2] staging: media: davinci_vpfe: Rewrite return statement in vpfe_video.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 29, 2013 at 12:14:14AM +0100, Andi Shyti wrote:
> Hi Greg,
> 
> > > If you write it like this:
> > > 
> > > 	return !ret ? ret : -ETIMEDOUT;
> > > 
> > > checkpatch shouldn't complain.
> > 
> > No, but I will.
> > 
> > That's horrid code, please be specific and readable, no one should ever
> > use ?: syntax except within function parameters.
> 
> why then don't we define it in the coding style, otherwise it's
> just a matter of taste.

Because defining _everything_ in coding style is a loosing battle,
sorry.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux