On Sun, Oct 20, 2013 at 08:40:43PM -0700, Lisa Nguyen wrote: > On Sun, Oct 20, 2013 at 8:07 PM, Peng, Tao <tao.peng@xxxxxxx> wrote: > > Hi Lisa, > > > > Thanks for the patch. I assume you were using coccinelle (or sed) to do the conversion. Are there change done by hand other than scripting? Can you please also put your scripts (such as in [PATCH 01/22]) in the commit message? > > > > Thanks, > > Tao > > > > Hi Tao, > > I didn't use any other script besides checkpatch.pl, which was > included in the kernel source code under the scripts directory. I used > sed to make replacements in vim for each file and relied on cscope and > grep to detect all the dependent files. > Don't rely on cscope alone. Use grep. Cscope misses a lot of things, like comments and really just a lot of things. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel