Re: [PATCH 00/22] staging: lustre: Update structs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Oct 20, 2013 at 8:07 PM, Peng, Tao <tao.peng@xxxxxxx> wrote:
> Hi Lisa,
>
> Thanks for the patch. I assume you were using coccinelle (or sed) to do the conversion. Are there change done by hand other than scripting? Can you please also put your scripts (such as in [PATCH 01/22]) in the commit message?
>
> Thanks,
> Tao
>

Hi Tao,

I didn't use any other script besides checkpatch.pl, which was
included in the kernel source code under the scripts directory. I used
sed to make replacements in vim for each file and relied on cscope and
grep to detect all the dependent files.

If there are other scripts I used, I will make a note of it in my
commit message(s).

After receiving feedback from Dan and Greg, I will respin a new patch
series to change one typedef at a time, rather than multiple ones for
one header file as I learned more about the building process.

Hope this answers your question and let me know if anything comes up.

Thanks,
Lisa

>>-----Original Message-----
>>From: Lisa Nguyen [mailto:lisa@xxxxxxxxxxxxxxx]
>>Sent: Monday, October 21, 2013 6:45 AM
>>To: gregkh@xxxxxxxxxxxxxxxxxxx
>>Cc: Peng, Tao; andreas.dilger@xxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxx
>>Subject: [PATCH 00/22] staging: lustre: Update structs
>>
>>This patchset includes all the changes needed to update the structs defined in
>>libcfs_hash.h. Doing this will eliminate the "Do not add new typedefs" warning
>>generated by checkpatch.pl and the updated format of those structs will meet
>>kernel coding style.
>>
>>Other header files and certain source files that use functions and structs
>>defined in libcfs_hash.h have updated struct variables.
>>
>>I have CC'ed the lustre driver authors to keep them informed of this update.
>>
>>Questions and comments are welcomed.
>>
>>Lisa Nguyen (22):
>>  staging: lustre: Remove all new typedefs in libcfs_hash.h
>>  staging: lustre: Update struct variables in lu_object.h
>>  staging: lustre: Update struct variables in lustre_dlm.h
>>  staging: lustre: Update struct variables in lustre_export.h
>>  staging: lustre: Update struct variables in lustre_net.h
>>  staging: lustre: Update struct variables in obd.h
>>  staging: lustre: Update struct variables in lov_internal.h
>>  staging: lustre: Update struct variables in hash.c
>>  staging: lustre: Update struct variables in ldlm_flock.c
>>  staging: lustre: Update struct variables in ldlm_lock.c
>>  staging: lustre: Update struct variables in ldlm_request.c
>>  staging: lustre: Update struct variables in ldlm_resource.c
>>  staging: lustre: Update struct variables in ldlm_lockd.c
>>  staging: lustre: Update struct variables in vvp_dev.c
>>  staging: lustre: Update struct variables in lov_pool.c
>>  staging: lustre: Update struct variables in cl_object.c
>>  staging: lustre: Update struct variables in genops.c
>>  staging: lustre: Update struct variables in lprocfs_status.c
>>  staging: lustre: Update struct variables in lu_object.c
>>  staging: lustre: Update struct variables in obd_config.c
>>  staging: lustre: Update struct variables in osc_quota.c
>>  staging: lustre: Update struct variables in connection.c
>>
>> .../lustre/include/linux/libcfs/libcfs_hash.h      | 280 ++++++++++-----------
>> drivers/staging/lustre/lustre/include/lu_object.h  |   4 +-
>> drivers/staging/lustre/lustre/include/lustre_dlm.h |   2 +-
>> .../staging/lustre/lustre/include/lustre_export.h  |   4 +-
>> drivers/staging/lustre/lustre/include/lustre_net.h |   4 +-
>> drivers/staging/lustre/lustre/include/obd.h        |  10 +-
>> drivers/staging/lustre/lustre/ldlm/ldlm_flock.c    |   8 +-
>> drivers/staging/lustre/lustre/ldlm/ldlm_lock.c     |   4 +-
>> drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c    |   8 +-
>> drivers/staging/lustre/lustre/ldlm/ldlm_request.c  |   4 +-
>> drivers/staging/lustre/lustre/ldlm/ldlm_resource.c |  34 +--
>> drivers/staging/lustre/lustre/libcfs/hash.c        | 270 ++++++++++----------
>> drivers/staging/lustre/lustre/llite/vvp_dev.c      |   2 +-
>> drivers/staging/lustre/lustre/lov/lov_internal.h   |   2 +-
>> drivers/staging/lustre/lustre/lov/lov_pool.c       |   8 +-
>> drivers/staging/lustre/lustre/obdclass/cl_object.c |   8 +-
>> drivers/staging/lustre/lustre/obdclass/genops.c    |   6 +-
>> .../lustre/lustre/obdclass/lprocfs_status.c        |   6 +-
>> drivers/staging/lustre/lustre/obdclass/lu_object.c |  42 ++--
>> .../staging/lustre/lustre/obdclass/obd_config.c    |  28 +--
>> drivers/staging/lustre/lustre/osc/osc_quota.c      |  10 +-
>> drivers/staging/lustre/lustre/ptlrpc/connection.c  |  14 +-
>> 22 files changed, 379 insertions(+), 379 deletions(-)
>>
>>--
>>1.8.1.2
>>
>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux