On 09/16/13 09:17, Jürgen Beisert wrote:
> Hi Jonathan,
>
> On Sunday 15 September 2013 12:35:29 Jonathan Cameron wrote:
>> [...]
>>> +static void mxs_lradc_reg_set(struct mxs_lradc *lradc, u32 val, u32 reg)
>>> +{
>>> + writel(val, lradc->base + reg + STMP_OFFSET_REG_SET);
>>> +}
>>> +
>>> +static void mxs_lradc_reg_clear(struct mxs_lradc *lradc, u32 val, u32 reg)
>>> +{
>>> + writel(val, lradc->base + reg + STMP_OFFSET_REG_CLR);
>>> +}
>>> +
>>
>> mxs_lradc_reg_write might be clearer?
>
> I would prefer the shorter name. Due to long macro names and long function
> names the lines in the code below needs more and more line breaks which is
> IMHO less helpfull to read the code.
Hmm. It's not entirely obvious what else this might be doing, but it is
also not obvious from the name that it is writing to the register...
I remain unconvinced by the short name!
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
