Hi Jonathan,
On Sunday 15 September 2013 12:35:29 Jonathan Cameron wrote:
> [...]
> > +static void mxs_lradc_reg_set(struct mxs_lradc *lradc, u32 val, u32 reg)
> > +{
> > + writel(val, lradc->base + reg + STMP_OFFSET_REG_SET);
> > +}
> > +
> > +static void mxs_lradc_reg_clear(struct mxs_lradc *lradc, u32 val, u32 reg)
> > +{
> > + writel(val, lradc->base + reg + STMP_OFFSET_REG_CLR);
> > +}
> > +
>
> mxs_lradc_reg_write might be clearer?
I would prefer the shorter name. Due to long macro names and long function
names the lines in the code below needs more and more line breaks which is
IMHO less helpfull to read the code.
Regards,
Juergen
--
Pengutronix e.K. | Juergen Beisert |
Linux Solutions for Science and Industry | http://www.pengutronix.de/ |
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
