Dear Dan Carpenter, > On Thu, Sep 05, 2013 at 12:16:18PM +0200, Jürgen Beisert wrote: > > I like this simplification, but all the other drivers for the MXS series > > of SoCs don't use such a method. Do you think this "new style" will be > > accepted? > > My lradc_plate_mask() is basically the same idea as what Marek said > about putting the logic into the define. > > LRADC....IRQ_MASK(id) (((id) == MX23) ? 0x1ff : 0x1fff) > > I don't know why Marek is complaining about churn though. This is > linux! We love churn! And especially in staging, it's our favorite > thing. :P About time to move this driver out of staging then ;-) Best regards, Marek Vasut _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel