On Mon, Aug 26, 2013 at 05:10:04PM +0200, Iker Pedrosa wrote:
> Second of the patches that fixes the lines over 80 characters in phy_calibration.c
>
> Signed-off-by: Iker Pedrosa <ikerpedrosam@xxxxxxxxx>
> ---
> drivers/staging/winbond/phy_calibration.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/winbond/phy_calibration.c b/drivers/staging/winbond/phy_calibration.c
> index 6635c85..a4f3773 100644
> --- a/drivers/staging/winbond/phy_calibration.c
> +++ b/drivers/staging/winbond/phy_calibration.c
> @@ -1233,8 +1233,10 @@ u8 _rx_iq_calibration_loop_winbond(struct hw_data *phw_data, u16 factor, u32 fre
> b_2 = (rot_image_q_b * 32768) / rot_tone_i_b -
> phw_data->iq_rsdl_phase_tx_d2;
>
> - PHY_DEBUG(("[CAL] ** iq_rsdl_gain_tx_d2 = %d\n", phw_data->iq_rsdl_gain_tx_d2));
> - PHY_DEBUG(("[CAL] ** iq_rsdl_phase_tx_d2= %d\n", phw_data->iq_rsdl_phase_tx_d2));
> + PHY_DEBUG(("[CAL] ** iq_rsdl_gain_tx_d2 = %d\n",
> + phw_data->iq_rsdl_gain_tx_d2));
Don't redo this, but really these should be aligned like this:
PHY_DEBUG(("[CAL] ** iq_rsdl_gain_tx_d2 = %d\n",
phw_data->iq_rsdl_gain_tx_d2));
In the end, we're going to remove all these debugging prints so it's
not worth redoing in a later patch. What you have is fine. The
message itself is sort of nonsense.
> + PHY_DEBUG(("[CAL] ** iq_rsdl_phase_tx_d2= %d\n",
> + phw_data->iq_rsdl_phase_tx_d2));
> PHY_DEBUG(("[CAL] ***** EPSILON/2 = %d\n", a_2));
> PHY_DEBUG(("[CAL] ***** THETA/2 = %d\n", b_2));
>
> @@ -1280,7 +1282,8 @@ u8 _rx_iq_calibration_loop_winbond(struct hw_data *phw_data, u16 factor, u32 fre
>
> /* e. */
> pwr_tone = (iqcal_tone_i*iqcal_tone_i + iqcal_tone_q*iqcal_tone_q);
> - pwr_image = (iqcal_image_i*iqcal_image_i + iqcal_image_q*iqcal_image_q)*factor;
> + pwr_image = (iqcal_image_i*iqcal_image_i +
> + iqcal_image_q*iqcal_image_q)*factor;
Don't resend, eventually, someone will have to fix these across the
whole driver but this should be:
pwr_image = (iqcal_image_i * iqcal_image_i +
iqcal_image_q * iqcal_image_q) * factor;
I've changed the alignment and added spaces around the math
operations.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
