[PATCH 00/15] staging: comedi: comedi_bond: some bug fixes and tidy up

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The "comedi_bond" driver can be used to map the DIO subdevices of some
other comedi devices into one, giant, uber DIO subdevice.  However, it
has a few bugs such as memory leaks (but only if a memory allocation
fails), buffer overflow when more than 256 channels are added, not
handling `COMEDI_INSN_BITS` properly when there are more than 32
channels, and various other problems.  Also it needs tidying up a bit
due to the use of CamelCase, etc.

Some of the changes involve changes to the "kcomedilib" module as well,
but that is only used by the "comedi_bond" module (for in-tree modules,
anyway, which is all we care about at the moment).

01) staging: comedi: comedi_bond: reformat some comments
02) staging: comedi: comedi_bond: shorten module description
03) staging: comedi: comedi_bond: rename CamelCase identifiers
04) staging: comedi: comedi_bond: no need to initialize file[]
05) staging: comedi: comedi_bond: return error code in do_dev_config()
06) staging: comedi: comedi_bond: change return value of
    bonding_attach()
07) staging: comedi: comedi_bond: use bitmap to record opened/closed
    minors
08) staging: comedi: comedi_bond: don't map channels individually
09) staging: comedi: comedi_bond: remove unused subdev_type
10) staging: comedi: comedi_bond: no need to free dev->private on detach
11) staging: comedi: comedi_bond: just check devprivs->devs once on
    detach
12) staging: comedi: comedi_bond: get INSN_CONFIG_DIO_QUERY info from
    horse's mouth
13) staging: comedi: comedi_bond: handle base channel for insn_bits
14) staging: comedi: comedi_bond: use krealloc() and fix memory leak
15) staging: comedi: comedi_bond: use correct minor device numbers in
    name

 drivers/staging/comedi/comedilib.h                 |   7 +-
 drivers/staging/comedi/drivers/comedi_bond.c       | 361 ++++++++++-----------
 .../staging/comedi/kcomedilib/kcomedilib_main.c    |  58 +++-
 3 files changed, 230 insertions(+), 196 deletions(-)
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux