Re: staging: comedi: dt9812: Resolves sparse endian warnings.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2013/07/30 04:07 PM, Shaun Laing wrote:
> Resolves warnings from the "sparse" checker of the form "warning: incorrect
> type in assignment (different base types)".
> 
> Signed-off-by: Shaun Laing <shaun@xxxxxxxxxxxx>

Okay, but we have two patches with the same subject line (apart from the
"[PATCH]" prefix missing from this one), and that might be confusing.

I suggest changing the subject to "staging: comedi: dt9812: Resolve
different base types warnings".

Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>

> ---
> diff --git a/drivers/staging/comedi/drivers/dt9812.c b/drivers/staging/comedi/drivers/dt9812.c
> index 6c60949..0bb2bd4 100644
> --- a/drivers/staging/comedi/drivers/dt9812.c
> +++ b/drivers/staging/comedi/drivers/dt9812.c
> @@ -188,8 +188,8 @@ enum {
>  };
>  
>  struct dt9812_flash_data {
> -	u16 numbytes;
> -	u16 address;
> +	__le16 numbytes;
> +	__le16 address;
>  };
>  
>  #define DT9812_MAX_NUM_MULTI_BYTE_RDS  \
> @@ -230,7 +230,7 @@ struct dt9812_rmw_multi {
>  };
>  
>  struct dt9812_usb_cmd {
> -	u32 cmd;
> +	__le32 cmd;
>  	union {
>  		struct dt9812_flash_data flash_data_info;
>  		struct dt9812_read_multi read_multi_info;
> 


-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>             )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587              )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux