On Thu, Jun 27, 2013 at 03:34:52PM +0530, navin patidar wrote:
> dev_warn() is preferred over pr_warning().
>
> container_of() is used to get usb_driver pointer from usbip_device container
> (stub_device or vhci_device), to get device structure required for dev_warn().
>
> Signed-off-by: navin patidar <navinp@xxxxxxx>
> ---
> drivers/staging/usbip/usbip_event.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/usbip/usbip_event.c b/drivers/staging/usbip/usbip_event.c
> index 82123be..1f3a571 100644
> --- a/drivers/staging/usbip/usbip_event.c
> +++ b/drivers/staging/usbip/usbip_event.c
> @@ -21,6 +21,8 @@
> #include <linux/export.h>
>
> #include "usbip_common.h"
> +#include "stub.h"
> +#include "vhci.h"
>
> static int event_handler(struct usbip_device *ud)
> {
> @@ -85,7 +87,14 @@ int usbip_start_eh(struct usbip_device *ud)
>
> ud->eh = kthread_run(event_handler_loop, ud, "usbip_eh");
> if (IS_ERR(ud->eh)) {
> - pr_warning("Unable to start control thread\n");
> + struct device *dev;
> +
> + if (ud->side == USBIP_STUB)
> + dev = &container_of(ud, struct stub_device, ud)->udev->dev;
> + else
> + dev = &container_of(ud, struct vhci_device, ud)->udev->dev;
Putting '&' in front of container_of seems odd, are you sure it's needed
here? If ud is a pointer, everything else should "just work" properly
without that.
Can you please fix this up?
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
