On Fri, Jun 21, 2013 at 10:54:40PM -0300, Raphael S. Carvalho wrote: > Well, there is no need to use strcmp since we can make a test of similar > semantic by using the var_id field of param. > I moved the test into the VAR_NUM:VAR_TIME case since VAR_STRING will > never be "voice". > > spk_xlate isn't used anymore (in line 608), then there is no difference > between using cp and buf in VAR_STRING case. > Besides, buf is a const char and those changes remove one uneeded line. > > I created the function spk_reset_default_value because it clarifies the > code and allows code reusing. > > Signed-off-by: Raphael S. Carvalho <raphael.scarv@xxxxxxxxx> > Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx> > --- > drivers/staging/speakup/kobjects.c | 73 +++++++++++++++++++---------------- > 1 files changed, 40 insertions(+), 33 deletions(-) This patch no longer applies to my tree, can you please refresh it against linux-next and resend, keeping Samuel's ack on it? thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
