[Originally posted 2013-06-19. Reposting to new driverdev-devel list.]
On 2013-06-19 16:10, Ian Abbott wrote:
On 2013-06-18 21:23, H Hartley Sweeten wrote:
The number of subdevices needed by the driver is based on the
'num_asics' reported by the boardinfo and each subdevice always
has 24 channels. Simplify the attach a bit.
We could probably assume all subdevices have the same number of channels
(MAX_CHANS_PER_SUBDEV, i.e. 24) and just skip the rounding stuff.
MAX_CHANS_PER_SUBDEV is probably better off just being called
CHANS_PER_SUBDEV if they all have the same number of channels.
All those calculations in the #defines do my head in. Replacing them
with simple integer values would be an improvement!
Never mind. You get rid of (most of) those defines in patch 17 anyway,
so you can ignore my previous comments on patches 11, 13 and 14.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
