Re: [PATCH 0/6] staging: comedi: addi-data: cleanup "common" code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[Originally posted 2013-06-19.  Reposting to new driverdev-devel list.]

On 2013-06-18 20:13, H Hartley Sweeten wrote:
Due to the cleanup of the add-data drivers some of the "common" code is
no longer needed. Tidy it up a bit.

H Hartley Sweeten (6):
   staging: comedi: addi-data: remove unused vars from private data
   staging: comedi: addi-data: simplify the PCI bar reading
   staging: comedi: addi-data: remove unused defines in addi_common.h
   staging: comedi: addi-data: remove unused vars from boardinfo
   staging: comedi: addi-data: remove unused 'i_Dma' present flag
   staging: comedi: addi-data: remove unused 'i_NbrTTLChannel' boardinfo

  .../staging/comedi/drivers/addi-data/addi_common.c | 54 ++++------------------
  .../staging/comedi/drivers/addi-data/addi_common.h | 44 ------------------
  .../staging/comedi/drivers/addi-data/addi_eeprom.c |  2 +-
  .../comedi/drivers/addi-data/hwdrv_apci3120.c      |  6 ---
  drivers/staging/comedi/drivers/addi_apci_3120.c    |  5 --
  5 files changed, 10 insertions(+), 101 deletions(-)

Looks fine to me. I'm holding off on submitting stuff until the list is back up.

Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux