Re: [PATCH 1/2] vme: tsi148: CR/CSR logic arround the wrong way

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 11, 2013 at 05:03:14PM +0100, Martyn Welch wrote:
> The logic in the init routine for the TSI148 is inverted. It isn't switching
> on the CR/CSR space when it should be and is reporting it's on when its not.
> 
> Correct the logic to do the right thing.
> 

This is fine, but for future reverence the original curly braces
were correct.  If either side of the if else statement has curly
braces then both sides get them.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux