Possible bug in vme_tsi148 in enabling CR/CSR space

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is an abstract from vme_tsi148.c:

...
2296         crat = ioread32be(bridge->base + TSI148_LCSR_CRAT);
2297         if (crat & TSI148_LCSR_CRAT_EN) {
2298                 dev_info(tsi148_bridge->parent, "Enabling CR/CSR space\n");
2299                 iowrite32be(crat | TSI148_LCSR_CRAT_EN,
2300                         bridge->base + TSI148_LCSR_CRAT);
2301         } else
2302                 dev_info(tsi148_bridge->parent, "CR/CSR already enabled\n");
...

Shouldn't this be like this ?

...
2297		if (!(crat & TSI148_LCSR_CRAT_EN))
...

Kind regards, 
Steven De Roo
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux