Re: [RFC 5/5] rtl8192u: fix identation in r8192U_core.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/01/2013 02:29 AM, Dan Carpenter wrote:
On Sat, Jun 01, 2013 at 02:07:18AM +0300, Xenia Ragiadakou wrote:
On 06/01/2013 01:47 AM, Dan Carpenter wrote:
On Fri, May 31, 2013 at 08:10:52PM +0300, Xenia Ragiadakou wrote:
This patch fixes identation and alignment in r8192U_core.c.
Also, removes spaces from idents when applicable.

Signed-off-by: Xenia Ragiadakou<burzalodowa@xxxxxxxxx>
---

Please take a look at changes in stage:
@@-2686,35 +2688,35 @@ static void rtl8192_read_eeprom_info(struct net_device *dev)
There are some changes that i don't know where they
came from. They do not alter the code though.
I am referring to the following sub-add pairs:
patch lines 922 and 923
patch lines 925 and 926
patch lines 928 and 945

I am worried about this but I don't understand it.  What do those
line numbers mean?  Please explain again.
They are the lines in the patch file where I saw the changes when
I was reviewing the patch.
I still don't understand what the question is.

regards,
dan carpenter

In the 5/5 patch there are the following changes:

-  priv->TxPowerLevelOFDM24G[i] = priv->EEPROMTxPowerLevelOFDM24G[0];
+ priv->TxPowerLevelCCK[i] = priv->EEPROMTxPowerLevelOFDM24G[0] + (priv->EEPROMTxPowerLevelCCK - priv->EEPROMTxPowerLevelOFDM24G[1]);


-  priv->TxPowerLevelOFDM24G[i] = priv->EEPROMTxPowerLevelOFDM24G[1];
+ priv->TxPowerLevelCCK[i] = priv->EEPROMTxPowerLevelCCK;

- priv->TxPowerLevelOFDM24G[i] = priv->EEPROMTxPowerLevelOFDM24G[2];
+ priv->TxPowerLevelCCK[i] = priv->EEPROMTxPowerLevelOFDM24G[2] + (priv->EEPROMTxPowerLevelCCK - priv->EEPROMTxPowerLevelOFDM24G[1]);


I did not make such a change. I don't know why these diffs appear in the patch.
I hope I am clear now hopefully.

Ksenia
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux