On 05/23/2013 04:50 PM, Dan Carpenter wrote:
On Thu, May 23, 2013 at 04:25:11PM +0300, Xenia Ragiadakou wrote:
On 05/23/2013 03:06 PM, Dan Carpenter wrote:
Actually, i did not know that the rtl8192u is not under development.
I thought that since it is under staging, it is currently under development
(it includes all these TODO, FIXME, unimplemented function bodies etc)
I will wait for the opinion of Greg on this and maybe before writing again
the patch for the printk replacement, i will first cleanup
completely the code.
You are confused about what I wrote.
The words "dead code" mean a line of code which is never run. For
example the print_buffer() function is never called. Instead of
debating if pr_cont() is appropriate in print_buffer() we should
just delete the whole function.
regards,
dan carpenter
Hi Dan,
I made some example prints as you suggested and i understood
what you mean (the pr_ prints in the loops that don't end with new
line look awful and the separate print of "\n" has no meaning).
So i will send a 3rd version of the patch which will apply the change
only to the places that appear meaningful. I will replace also pr_devel
(if rest any) with pr_debug. And if it is acked, in another patch,
i will eliminate the deadcode and the code into John's debug defines.
That it is the best that i can think now. If you have any other
suggestions I will be glad to hear them.
Ksenia
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
