Re: [PATCH v2 4/4] rtl8192u: fix printk calls in r8192U_core.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 23, 2013 at 04:25:11PM +0300, Xenia Ragiadakou wrote:
> On 05/23/2013 03:06 PM, Dan Carpenter wrote:
> Actually, i did not know that the rtl8192u is not under development.
> I thought that since it is under staging, it is currently under development
> (it includes all these TODO, FIXME, unimplemented function bodies etc)
> I will wait for the opinion of Greg on this and maybe before writing again
> the patch for the printk replacement, i will first cleanup
> completely the code.
> 

You are confused about what I wrote.

The words "dead code" mean a line of code which is never run.  For
example the print_buffer() function is never called.  Instead of
debating if pr_cont() is appropriate in print_buffer() we should
just delete the whole function.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux