On 22 May 2013 14:59, Santosh Y <santoshsy@xxxxxxxxx> wrote: > On Wed, May 22, 2013 at 2:37 PM, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote: >> Use NULL instead of 0 for pointers. >> >> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx> >> --- >> drivers/staging/speakup/main.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c >> index 4769c89..f547250 100644 >> --- a/drivers/staging/speakup/main.c >> +++ b/drivers/staging/speakup/main.c >> @@ -2033,7 +2033,7 @@ speakup_key(struct vc_data *vc, int shift_state, int keycode, u_short keysym, >> if (keycode >= MAX_KEY) >> goto no_map; >> key_info = spk_our_keys[keycode]; >> - if (key_info == 0) >> + if (key_info == NULL) > > I guess if (!key_info) is more appropriate as per the kernel coding style. Sounds good. Sent the revised version. -- With warm regards, Sachin _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
