Re: [PATCH 4/6] Staging: speakup/main: Use NULL instead of 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 22, 2013 at 2:37 PM, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote:
> Use NULL instead of 0 for pointers.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
> ---
>  drivers/staging/speakup/main.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> index 4769c89..f547250 100644
> --- a/drivers/staging/speakup/main.c
> +++ b/drivers/staging/speakup/main.c
> @@ -2033,7 +2033,7 @@ speakup_key(struct vc_data *vc, int shift_state, int keycode, u_short keysym,
>         if (keycode >= MAX_KEY)
>                 goto no_map;
>         key_info = spk_our_keys[keycode];
> -       if (key_info == 0)
> +       if (key_info == NULL)

I guess if (!key_info) is more appropriate as per the kernel coding style.

>                 goto no_map;
>         /* Check valid read all mode keys */
>         if ((cursor_track == read_all_mode) && (!up_flag)) {
> @@ -2265,7 +2265,7 @@ static int __init speakup_init(void)
>              (var->var_id >= 0) && (var->var_id < MAXVARS); var++)
>                 speakup_register_var(var);
>         for (i = 1; spk_punc_info[i].mask != 0; i++)
> -               spk_set_mask_bits(0, i, 2);
> +               spk_set_mask_bits(NULL, i, 2);
>
>         spk_set_key_info(spk_key_defaults, spk_key_buf);
>
> --
> 1.7.9.5
>
> _______________________________________________
> devel mailing list
> devel@xxxxxxxxxxxxxxxxxxxxxx
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



-- 
~Santosh
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux