On Thu, Apr 18, 2013 at 11:27:36AM +0300, Dan Carpenter wrote:
> On Wed, Apr 17, 2013 at 11:17:42AM -0700, H Hartley Sweeten wrote:
> > static int das16_cmd_test(struct comedi_device *dev, struct comedi_subdevice *s,
> > @@ -1122,11 +1124,9 @@ static int das16_attach(struct comedi_device *dev, struct comedi_devconfig *it)
> > /* Request an additional region for the 8255 */
> > ret = __comedi_request_region(dev, dev->iobase + 0x400,
> > board->size & 0x3ff);
> > - if (ret) {
> > - release_region(dev->iobase, 0x10);
> > - dev->iobase = 0;
> > - return -EIO;
> > - }
> > + if (ret)
> > + return ret;
> > + devpriv->extra_iobase = dev->iobase + 0x400;
> > }
> >
> > /* probe id bits to make sure they are consistent */
>
> I understand that we clean up later but can the board work if the
> second request region fails? That's why we don't return an error
> here any more?
Gar. Sorry. Ignore me.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
