Re: [PATCH 33/50] staging: omap-thermal: refactor APIs handling threshold values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 16-03-2013 04:39, Dan Carpenter wrote:
On Fri, Mar 15, 2013 at 09:00:21AM -0400, Eduardo Valentin wrote:
  	if (ret) {
  		dev_err(bg_ptr->dev, "failed to read thot\n");
-		return -EIO;
+		ret = -EIO;
+		goto exit;
  	}

-	*thot = temp;
+	*val = temp;

+exit:
  	return 0;
  }


The bunny hop has introduced a bug and this always returns success.

What was the bug introduced?

I will send a patch to fix the return value.


regards,
dan carpenter




_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux