On Fri, Mar 15, 2013 at 09:00:21AM -0400, Eduardo Valentin wrote: > if (ret) { > dev_err(bg_ptr->dev, "failed to read thot\n"); > - return -EIO; > + ret = -EIO; > + goto exit; > } > > - *thot = temp; > + *val = temp; > > +exit: > return 0; > } The bunny hop has introduced a bug and this always returns success. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel