On Thu, Mar 07, 2013 at 06:27:18PM +0800, Chen Gang wrote: > > 于 2013年03月07日 13:38, Chen Gang 写道: > > 于 2013年03月07日 13:19, Dan Carpenter 写道: > >> > Sending the patch included at the bottom of an email makes the > >> > git log a bit messy. All the discussion at the top of the email > >> > gets included at the top of the git log. Try it with git am to > >> > see what I mean, > >> > 1) save the entire email as text. > >> > 2) cat raw_email_with_headers.txt | git am > >> > > >> > Put this kind of discussion after the Signed-off-by line, infront > >> > of the diffstat. That section of the email is not saved to the > >> > git log. > > ok, thank you, I will try, now. > > after tried, I did not find any issues about my original reply > if delete the wast things before "From: Chen Gang <gang.chen@xxxxxxxxxxx>" line. > "git am" can succeed apply it. It applies but the commit message is messy. commit 844267882af030bf64db44949267b29c13953e5c Author: Chen Gang <gang.chen@xxxxxxxxxxx> Date: Thu Mar 7 12:58:21 2013 +0800 drivers/staging/zcache: using strlcpy instead of strncpy 于 2013年03月05日 16:45, Greg KH 写道: > This patch fails to apply to my tree :( the relative file has been changed much during these days. I need send the patch again based on next-20130307 tree. I append the patch below, if need send it with patch v2, please tell me, thanks. From: Chen Gang <gang.chen@xxxxxxxxxxx> Date: Thu, 7 Mar 2013 12:53:31 +0800 Subject: [PATCH] drivers/staging/zcache: using strlcpy instead of strncpy for NUL terminated string, need alway set '\0' in the end. Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx> regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel