Re: [PATCH] drivers/staging/zcache: using strlcpy instead of strncpy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 17, 2013 at 10:30:01AM +0800, Chen Gang wrote:
> 
>   for NUL terminated string, need alway set '\0' in the end.
> 
> Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx>
> ---
>  drivers/staging/zcache/zcache-main.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/zcache/zcache-main.c b/drivers/staging/zcache/zcache-main.c
> index 4456ab4..e6daed7 100644
> --- a/drivers/staging/zcache/zcache-main.c
> +++ b/drivers/staging/zcache/zcache-main.c
> @@ -19,6 +19,7 @@
>  #include <linux/slab.h>
>  #include <linux/spinlock.h>
>  #include <linux/types.h>
> +#include <linux/string.h>
>  #include <linux/atomic.h>
>  #include <linux/math64.h>
>  #include <linux/crypto.h>
> @@ -1899,7 +1900,7 @@ __setup("nocleancacheignorenonactive", no_cleancache_ignore_nonactive);
>  
>  static int __init enable_zcache_compressor(char *s)
>  {
> -	strncpy(zcache_comp_name, s, ZCACHE_COMP_NAME_SZ);
> +	strlcpy(zcache_comp_name, s, sizeof(zcache_comp_name));

This patch fails to apply to my tree :(

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux