> > > {sigh} you just made me have to edit your patch by hand, you now owe me > > > a beer... > > > > > Should we codify that :-) > > > > > > diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches > > index c379a2a..f879c60 100644 > > --- a/Documentation/SubmittingPatches > > +++ b/Documentation/SubmittingPatches > > @@ -94,6 +94,7 @@ includes updates for subsystem X. Please apply." > > The maintainer will thank you if you write your patch description in a > > form which can be easily pulled into Linux's source code management > > system, git, as a "commit log". See #15, below. > > +If the maintainer has to hand-edit your patch, you owe them a beer. > > > > If your description starts to get long, that's a sign that you probably > > need to split up your patch. See #3, next. > > Yes we do need to codify this, but let's be fair, not everyone likes > beer: > > diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches > index c379a2a..d1bec01 100644 > --- a/Documentation/SubmittingPatches > +++ b/Documentation/SubmittingPatches > @@ -93,7 +93,9 @@ includes updates for subsystem X. Please apply." > > The maintainer will thank you if you write your patch description in a > form which can be easily pulled into Linux's source code management > -system, git, as a "commit log". See #15, below. > +system, git, as a "commit log". See #15, below. If the maintainer has > +to hand-edit your patch, you owe them the beverage of their choice the > +next time you see them. > > If your description starts to get long, that's a sign that you probably > need to split up your patch. See #3, next. Does that mean you owe Linus a whiskey bottle since you didn't properly sign this patch :-) _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel