On Wed, Jan 30, 2013 at 06:21:59PM +0100, Greg Kroah-Hartman wrote: > On Wed, Jan 30, 2013 at 09:41:55AM -0600, Seth Jennings wrote: > > On 01/30/2013 09:36 AM, Seth Jennings wrote:> zs_create_pool() > > currently takes a name argument which is > > > never used in any useful way. > > > > > > This patch removes it. > > > > > > Signed-off-by: Seth Jennings <sjenning@xxxxxxxxxxxxxxxxxx> > > > > Crud, forgot the Acks... > > > > Acked-by: Nitin Gupta <ngupta@xxxxxxxxxx> > > Acked-by: Rik van Riel <riel@xxxxxxxxxx> > > {sigh} you just made me have to edit your patch by hand, you now owe me > a beer... > Should we codify that :-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index c379a2a..f879c60 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -94,6 +94,7 @@ includes updates for subsystem X. Please apply." The maintainer will thank you if you write your patch description in a form which can be easily pulled into Linux's source code management system, git, as a "commit log". See #15, below. +If the maintainer has to hand-edit your patch, you owe them a beer. If your description starts to get long, that's a sign that you probably need to split up your patch. See #3, next. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel