Re: [PATCH 10/11] Staging: bcm: Remove typedef for _LEDColors and call directly.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Dec 16, 2012 at 09:48:44PM +0300, Dan Carpenter wrote:
> On Fri, Dec 14, 2012 at 07:26:53PM -0500, Kevin McKinney wrote:
> > This patch removes typedef for _LEDColors, and changes
> > the name of the enum to bcm_led_colors. In addition,
> > any calls to LEDColors are changed to call directly.
> > 
> 
> There aren't any calls changed...  You could probably just delete
> this enum.  :P
>

Yeah, I noticed this but when I removed this enum, I was unable to compile because
of these lines of code in led_controlc:
		switch (ucGPIOInfo[ucIndex]) {
		case RED_LED:
			GPIO_Array[RED_LED] = ucIndex;
			Adapter->gpioBitMap |= (1 << ucIndex);
			break;
		case BLUE_LED:
			GPIO_Array[BLUE_LED] = ucIndex;
			Adapter->gpioBitMap |= (1 << ucIndex);
			break;
		case YELLOW_LED:
			GPIO_Array[YELLOW_LED] = ucIndex;
			Adapter->gpioBitMap |= (1 << ucIndex);
			break;
		case GREEN_LED:
			GPIO_Array[GREEN_LED] = ucIndex;
			Adapter->gpioBitMap |= (1 << ucIndex);
			break;
		default:
			break;
		}

It appears this enum is being referenced here.

Thanks,
Kevin
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux