Re: [PATCH 1/1] staging: gdm72xx: Remove redundant null check before kfree in gdm_wimax.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 22 November 2012 03:21, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, Nov 21, 2012 at 08:38:29PM +0530, Sachin Kamat wrote:
>> On 21 November 2012 14:47, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>> > On Wed, Nov 21, 2012 at 11:29:36AM +0530, Sachin Kamat wrote:
>> >> kfree on a null pointer is a no-op.
>> >>
>> >
>> > kdelete() used to accept NULL pointers but now it will oops.
>>
>> You are right. We can either leave it the way it was (i.e. drop this
>> patch) or I remove the NULL assignment
>> and re-send?
>
> Look at the code and determine what needs to be done.
>
> thanks,
>
> greg k-h

I had got a little confused about the whole thing :)
Thanks Dan for pointing out a valid issue with this patch.
Please drop this patch and sorry for the noise.

-- 
With warm regards,
Sachin
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux