Re: [PATCH 1/2] mm: Export vm_committed_as

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 8 Nov 2012, Andrew Morton wrote:

> > > I don't think you should export the symbol itself to modules but rather a
> > > helper function that returns s64 that just wraps
> > > percpu_counter_read_positive() which your driver could use instead.
> > > 
> > > (And why percpu_counter_read_positive() returns a signed type is a
> > > mystery.)
> > 
> > Yes, this makes sense. I just want to access (read) this metric. Andrew, if you are willing to
> > take this patch, I could send one.
> 
> Sure.  I suppose that's better, although any module which modifies
> committed_as would never pass review (rofl).
> 

I was thinking of a function that all hypervisors can use (since xen also 
uses it) that can be well documented and maintain the semantics that they 
expect, whether that relines on vm_commited_as in the future or not.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux