On Tue, Oct 16, 2012 at 06:09:58PM +0100, Ian Abbott wrote: > On 2012-10-15 19:26, H Hartley Sweeten wrote: > >On Monday, October 15, 2012 4:20 AM, Ian Abbott wrote: > >> > >>Tag pointers to remapped I/O memory with `__iomem` and remove the > >>`volatile` qualifiers. > >> > >>Signed-off-by: Ian Abbott <abbotti@xxxxxxxxx> > > > >I'm still not a fan of the iobase pointer being a struct * and not a void *. > > There are quite a few Linux drivers that use a similar trick though. Try: > > grep -r --include='*.c' 'struct [A-Za-z0-9_]* __iomem' > /usr/src/linux/drivers > > (replacing /usr/src/linux/drivers as appropriate). I don't like it either, but there is precedent for it, so I'll allow it. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
