Re: [PATCH v2] staging: comedi: jr3_pci: add __iomem tags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2012-10-15 19:26, H Hartley Sweeten wrote:
On Monday, October 15, 2012 4:20 AM, Ian Abbott wrote:

Tag pointers to remapped I/O memory with `__iomem` and remove the
`volatile` qualifiers.

Signed-off-by: Ian Abbott <abbotti@xxxxxxxxx>

I'm still not a fan of the iobase pointer being a struct * and not a void *.

There are quite a few Linux drivers that use a similar trick though.  Try:

grep -r --include='*.c' 'struct [A-Za-z0-9_]* __iomem' /usr/src/linux/drivers

(replacing /usr/src/linux/drivers as appropriate).

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux