On Monday, September 24, 2012 7:43 PM, H Hartley Sweeten wrote: > > Use the cfc_check_trigger_src() helper for Step 1 in all the > driver cmdtest functions. > > Use the cfc_check_trigger_is_unique() helper for Step 2 in all > the driver cmdtest functions. Note that single source triggers > do not need to be checked, they are already unique if they pass > Step 1. > > The Step 2 checks should also not modify the trigger sources. > Remove the couple cases that are. > > For aesthetic reasons, change the comments in the cmdtest > functions for steps 1 and 2 so that they are all the same. > > Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx> > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Gah.. The Reported-by sign-off for Dan Carpenter should not be in this patch. Sorry about that. > Cc: Ian Abbott <abbotti@xxxxxxxxx> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > --- > > This patch is quite large. If needed I can try splitting it up. > > drivers/staging/comedi/drivers/8255.c | 37 ++--- > .../comedi/drivers/addi-data/hwdrv_apci3120.c | 55 ++------ > .../comedi/drivers/addi-data/hwdrv_apci3200.c | 67 +++------ > drivers/staging/comedi/drivers/adl_pci9111.c | 2 +- > drivers/staging/comedi/drivers/adl_pci9118.c | 73 +++------- > drivers/staging/comedi/drivers/adv_pci1710.c | 2 +- > drivers/staging/comedi/drivers/amplc_dio200.c | 51 ++----- > drivers/staging/comedi/drivers/amplc_pc236.c | 36 ++--- > drivers/staging/comedi/drivers/amplc_pci224.c | 60 +++----- > drivers/staging/comedi/drivers/amplc_pci230.c | 146 ++++++-------------- > drivers/staging/comedi/drivers/cb_das16_cs.c | 50 ++----- > drivers/staging/comedi/drivers/cb_pcidas.c | 102 ++++---------- > drivers/staging/comedi/drivers/cb_pcidas64.c | 106 ++++----------- > drivers/staging/comedi/drivers/cb_pcidda.c | 59 ++------ > drivers/staging/comedi/drivers/comedi_parport.c | 37 ++--- > drivers/staging/comedi/drivers/comedi_test.c | 43 ++---- > drivers/staging/comedi/drivers/das16.c | 52 +++---- > drivers/staging/comedi/drivers/das16m1.c | 44 ++---- > drivers/staging/comedi/drivers/das1800.c | 58 +++----- > drivers/staging/comedi/drivers/das800.c | 44 ++---- > drivers/staging/comedi/drivers/dmm32at.c | 51 +++---- > drivers/staging/comedi/drivers/dt2814.c | 42 ++---- > drivers/staging/comedi/drivers/dt282x.c | 89 +++--------- > drivers/staging/comedi/drivers/dt3000.c | 36 ++--- > drivers/staging/comedi/drivers/gsc_hpdi.c | 41 ++---- > drivers/staging/comedi/drivers/me4000.c | 117 ++++------------ > drivers/staging/comedi/drivers/ni_6527.c | 37 ++--- > drivers/staging/comedi/drivers/ni_65xx.c | 37 ++--- > drivers/staging/comedi/drivers/ni_at_a2150.c | 44 ++---- > drivers/staging/comedi/drivers/ni_atmio16d.c | 48 ++----- > drivers/staging/comedi/drivers/ni_labpc.c | 52 ++----- > drivers/staging/comedi/drivers/ni_mio_common.c | 151 ++++++--------------- > drivers/staging/comedi/drivers/ni_pcidio.c | 47 ++----- > drivers/staging/comedi/drivers/ni_tiocmd.c | 61 +++------ > drivers/staging/comedi/drivers/pcl711.c | 43 ++---- > drivers/staging/comedi/drivers/pcl812.c | 45 ++---- > drivers/staging/comedi/drivers/pcl816.c | 46 ++----- > drivers/staging/comedi/drivers/pcl818.c | 41 ++---- > drivers/staging/comedi/drivers/pcm_common.c | 56 ++------ > drivers/staging/comedi/drivers/quatech_daqp_cs.c | 55 +++----- > drivers/staging/comedi/drivers/rtd520.c | 55 ++------ > drivers/staging/comedi/drivers/s626.c | 60 +++----- > drivers/staging/comedi/drivers/skel.c | 68 ++++------ > drivers/staging/comedi/drivers/usbdux.c | 130 ++++++------------ > drivers/staging/comedi/drivers/usbduxfast.c | 62 +++------ > drivers/staging/comedi/drivers/usbduxsigma.c | 125 +++++------------ > 46 files changed, 766 insertions(+), 1997 deletions(-) Greg, Assuming this patch is ok, if you have problems merging this patch could you suggest how you would like it split up? Thanks, Hartley _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
