> From: Sasha Levin [mailto:levinsasha928@xxxxxxxxx] > Subject: Re: [RFC] mm: add support for zsmalloc and zcache Sorry for delayed response! > On 09/22/2012 03:31 PM, Sasha Levin wrote: > > On 09/21/2012 09:14 PM, Dan Magenheimer wrote: > >>>> +#define MAX_CLIENTS 16 > >>>> > >>>> Seems a bit arbitrary. Why 16? > >> Sasha Levin posted a patch to fix this but it was tied in to > >> the proposed KVM implementation, so was never merged. > >> > > > > My patch changed the max pools per client, not the maximum amount of clients. > > That patch has already found it's way in. > > > > (MAX_CLIENTS does look like an arbitrary number though). > > btw, while we're on the subject of KVM, the implementation of tmem/kvm was > blocked due to insufficient performance caused by the lack of multi-page > ops/batching. Hmmm... I recall that was an unproven assertion. The tmem/kvm implementation was not exposed to any wide range of workloads IIRC? Also, the WasActive patch is intended to reduce the problem that multi-guest high volume reads would provoke, so any testing without that patch may be moot. > Are there any plans to make it better in the future? If it indeed proves to be a problem, the ramster-merged zcache (aka zcache2) should be capable of managing a "split" zcache implementation, i.e. zcache executing in the guest and "overflowing" page cache pages to the zcache in the host, which should at least ameliorate most of Avi's concern. I personally have no plans to implement that, but would be willing to assist if others attempt to implement it. The other main concern expressed by the KVM community, by Andrea, was zcache's lack of ability to "overflow" frontswap pages in the host to a real swap device. The foundation for that was one of the objectives of the zcache2 redesign; I am working on a "yet-to-be-posted" patch built on top of zcache2 that will require some insight and review from MM experts. Dan _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
