On 2012/09/19 08:10 PM, Dan Carpenter wrote: > Gar. Moving the pointer around sucks. It's just not worth it. It > makes the code more complicated. In the end, we're going to audit > the ioctls first when we look for security bugs in this code. The > chance that a bug is going to be introduced because of a missing > __user tag is not very high. > > Of course, the memory leak fixes are good and the pass by reference > changes are good. > > It's not my code and all, but the way it's done now is the simplest. Apart from mixing user and kernel pointers in the same type and some ugly-looking workarounds in the CONFIG_COMPAT code? -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
