Gar. Moving the pointer around sucks. It's just not worth it. It makes the code more complicated. In the end, we're going to audit the ioctls first when we look for security bugs in this code. The chance that a bug is going to be introduced because of a missing __user tag is not very high. Of course, the memory leak fixes are good and the pass by reference changes are good. It's not my code and all, but the way it's done now is the simplest. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel