re: staging/rts_pstor: Use pr_ or dev_ printks in rtsx.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Toshiaki Yamane,

This is a semi-automatic email about new static checker warnings.

The patch d084610bb1e8: "staging/rts_pstor: Use pr_ or dev_ printks 
in rtsx.c" from Sep 16, 2012, leads to the following Smatch complaint:

drivers/staging/rts_pstor/rtsx.c:396 rtsx_resume()
	 warn: variable dereferenced before check 'dev' (see line 394)

drivers/staging/rts_pstor/rtsx.c
   393	
   394		dev_info(&dev->pci->dev, "Ready to resume\n");
                         ^^^^^^^^^^^^^^
New dereference.

   395	
   396		if (!dev) {
                    ^^^^
Old check.

   397			dev_err(&dev->pci->dev, "Invalid memory\n");
                                ^^^^^^^^^^^^^^
Another new dereference.

   398			return 0;

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux