Hello Toshiaki Yamane,
This is a semi-automatic email about new static checker warnings.
The patch d084610bb1e8: "staging/rts_pstor: Use pr_ or dev_ printks
in rtsx.c" from Sep 16, 2012, leads to the following Smatch complaint:
drivers/staging/rts_pstor/rtsx.c:357 rtsx_suspend()
warn: variable dereferenced before check 'dev' (see line 355)
drivers/staging/rts_pstor/rtsx.c
354
355 dev_info(&dev->pci->dev, "Ready to suspend\n");
^^^^^^^^^^^^^
New dereference.
356
357 if (!dev) {
^^^^
Old check.
358 dev_err(&dev->pci->dev, "Invalid memory\n");
^^^^^^^^^^^^
Another NULL dereference.
359 return 0;
The best option is to audit the code and determine if the checks are
needed or not. If the pointer is always valid, you can just remove the
check. Otherwise, remove the dereference (use pr_err()).
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
