Re: [PATCH 07/21] staging: xgifb: avoid copy-pasting LCD data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Sep 10, 2012 at 11:31:42PM +0200, Peter Hüwe wrote:
> Am Montag, 10. September 2012, 23:15:18 schrieb Aaro Koskinen:
> > +#define XGI_CetLCD1400x1050Data XGI_CetLCD1280x1024Data
> 
> Hi,
> 
> why the define and not rewrite and maybe simplify the code?
> (that they use the same table)

It's for simplicity. I think the code and the patch is more readable if
XGI_CetLCD1400x1050Data is still left there.

And yes, the handling of LCD data should be re-written in a similar way
as it was done for TV data in 11/21 of this series. But I think that's
a task for future/incremental patches.

Thanks,

A.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux