Am Montag, 10. September 2012, 23:15:18 schrieb Aaro Koskinen:
> Share the common data tables instead of having the same data in multiple
> tables.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@xxxxxx>
> ---
> drivers/staging/xgifb/vb_table.h | 37
> +++---------------------------------- 1 files changed, 3 insertions(+), 34
> deletions(-)
>
> diff --git a/drivers/staging/xgifb/vb_table.h
> b/drivers/staging/xgifb/vb_table.h index 1c16846..d823bb0 100644
> --- a/drivers/staging/xgifb/vb_table.h
> +++ b/drivers/staging/xgifb/vb_table.h
> @@ -525,18 +525,7 @@ static struct SiS_LCDData XGI_StLCD1600x1200Data[] =
> { {1, 1, 2160, 1250, 2160, 1250} /* 09 (1600x1200) */
> };
>
> -static struct SiS_LCDData XGI_CetLCD1400x1050Data[] = {
> - {1, 1, 1688, 1066, 1688, 1066}, /* 00 (320x200,320x400,
> - 640x200,640x400) */
> - {1, 1, 1688, 1066, 1688, 1066}, /* 01 (320x350,640x350) */
> - {1, 1, 1688, 1066, 1688, 1066}, /* 02 (360x400,720x400) */
> - {1, 1, 1688, 1066, 1688, 1066}, /* 03 (720x350) */
> - {1, 1, 1688, 1066, 1688, 1066}, /* 04 (640x480x60Hz) */
> - {1, 1, 1688, 1066, 1688, 1066}, /* 05 (800x600x60Hz) */
> - {1, 1, 1688, 1066, 1688, 1066}, /* 06 (1024x768x60Hz) */
> - {1, 1, 1688, 1066, 1688, 1066}, /* 07 (1280x1024x60Hz) */
> - {1, 1, 1688, 1066, 1688, 1066} /* 08 (1400x1050x60Hz) */
> -};
> +#define XGI_CetLCD1400x1050Data XGI_CetLCD1280x1024Data
Hi,
why the define and not rewrite and maybe simplify the code?
(that they use the same table)
Peter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
