On Fri, Jul 20, 2012 at 04:02:44PM +0000, KY Srinivasan wrote:
> > On Fri, Jul 20, 2012 at 10:03:08AM +0200, Bjørn Mork wrote:
> > > Use OS version number in the guest ID as recommended by Microsoft
> > >
> > > Signed-off-by: Bjørn Mork <bjorn@xxxxxxx>
> > > ---
> > > So how about something like this? Yes, I know including
> > > linux/version.h often is unwanted, but the spec does
> > > recommend using the actual OS version in the guest ID
> > >
> > > Yes, this will be offensive again when Linux is at
> > > version 181.0, but we might have found a better solution by
> > > then :-)
> > >
> > >
> > > drivers/hv/hyperv_vmbus.h | 20 ++++++++++++++++----
> > > 1 file changed, 16 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h
> > > index b9426a6..cc0c3f0 100644
> > > --- a/drivers/hv/hyperv_vmbus.h
> > > +++ b/drivers/hv/hyperv_vmbus.h
> > > @@ -29,6 +29,7 @@
> > > #include <asm/sync_bitops.h>
> > > #include <linux/atomic.h>
> > > #include <linux/hyperv.h>
> > > +#include <linux/version.h>
> > >
> > > /*
> > > * The below CPUID leaves are present if
> > VersionAndFeatures.HypervisorPresent
> > > @@ -410,10 +411,21 @@ enum {
> > >
> > > #define HV_PRESENT_BIT 0x80000000
> > >
> > > -#define HV_LINUX_GUEST_ID_LO 0x00000000
> > > -#define HV_LINUX_GUEST_ID_HI 0xB16B00B5
> > > -#define HV_LINUX_GUEST_ID (((u64)HV_LINUX_GUEST_ID_HI
> > << 32) | \
> > > - HV_LINUX_GUEST_ID_LO)
> > > +/* Linux vendor ID allocated by Microsoft */
> > > +#define HV_LINUX_GUEST_ID_VENDOR 0xB16B
> > > +
> > > +/* Creating a guest ID conforming to the encoding recommended by
> > > + * Microsoft, with variant and build fixed to 0
> >
> > We could use the kernel build number here as well, if we really wanted
> > it, right?
> >
> > Otherwise, I like this patch, KY, any objection to me taking it?
>
> Greg,
>
> If it is ok with you can we wait a couple of days. I am pushing to get information
> back from folks within MSFT. I am hoping we can fix this issue soon.
Ok, I'll hold on to it for a week or so.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
